♻️CI: modularizing CI workflow towards faster feedback #8001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:infra+ops
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8001 +/- ##
==========================================
- Coverage 87.88% 87.87% -0.02%
==========================================
Files 1853 1853
Lines 71478 71478
Branches 1258 1258
==========================================
- Hits 62822 62814 -8
- Misses 8292 8300 +8
Partials 364 364
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
Author
|
@mergify queue |
Contributor
🛑 The pull request has been removed from the queue
|
sanderegg
requested review from
bisgaard-itis,
Copilot,
matusdrobuliak66 and
odeimaiz
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CI workflow to set up a common environment for SimCore jobs and adds a new debugging target for mypy. Key changes include:
- Introduction of a new “mypy-debug” target in the Makefile.
- Refactoring of numerous CI workflow files to use a common composite action for environment setup.
- Addition of new composite actions for setting up the SimCore environment and for downloading and loading Docker images.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/common.Makefile | Added new target “mypy-debug” for enhanced mypy profiling. |
| mypy.ini | Minor formatting adjustment. |
| .github/workflows/ci-testing-deploy.yml | Updated multiple jobs to use “Setup environment” via a composite action. |
| .github/workflows/_reusable-build-images.yml | Refactored to use the common environment setup action. |
| .github/actions/setup-simcore-env/action.yml | Added a new composite action for environment setup. |
| .github/actions/download-load-docker-images/action.yml | Introduced a composite action for downloading and loading Docker images. |
pcrespov
reviewed
Jun 27, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
I love it! thx!
- the idea of running drafts differently is also very nice!
pcrespov
approved these changes
Jun 27, 2025
matusdrobuliak66
approved these changes
Jun 28, 2025
|
Contributor
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
Member
Author
|
@Mergifyio requeue |
Contributor
✅ This pull request will be re-embarked automaticallyThe followup |
Contributor
🟠 Waiting for conditions to match
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Running the CI and looking at the workflow file is not a nice experience. This PR is a first step towards rationalizing the CI runs.
This PR modularizes towards simpler CI workflow file with a longer term goal to have maybe faster CI feedback. Ideas currently around are:
This PR should not have any effect for now in terms of functionality but more in terms of sustainability